Skip to content

Conversation

daynual
Copy link
Contributor

@daynual daynual commented Sep 12, 2025

Clean up trailing whitespace and fix grammatical typo in tutorial.md.

@daynual
Copy link
Contributor Author

daynual commented Sep 12, 2025

Successfully builds and generates code:

❯ ./scripts/generate_code.py

warning:
  cannot generate code directly from .proto files

Fields in struct ProtoMessage have gap between ids
Fields in struct OtherMessage have gap between ids
When you use --proto, that you should check for conformity yourself, using the existing --conform/home/dan/flatbuffers/flatc:
warning:
  /home/dan/flatbuffers/tests/rust_namer_test.fbs:26: 8: warning: field names should be lowercase snake_case, got: Message

I get the same warning building on main branch. Looks unrelated to these changes.

Originally I intended to create this PR just for bb268bf, but saw a bunch of trailing whitespace. I can drop that commit if requested.

@fliiiix
Copy link
Contributor

fliiiix commented Sep 24, 2025

Did you look at the generated output? As white space can be used in md to produce a line break. https://www.markdownguide.org/basic-syntax/#line-break-best-practices

@daynual
Copy link
Contributor Author

daynual commented Sep 25, 2025

Did you look at the generated output? As white space can be used in md to produce a line break. https://www.markdownguide.org/basic-syntax/#line-break-best-practices

Good catch! I double checked the generated output. The only place it made a difference was in:
docs/source/languages/c.md

I have reverted that single line change.

@fliiiix
Copy link
Contributor

fliiiix commented Sep 25, 2025

@aardappel this would be a cool mr to be merged :)

@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit 27325e0 into google:master Sep 25, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants